Remove compilation units for classes that have already been loaded #3700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
previously requested changes
Dec 24, 2017
|
Now in both cases the file/class names are deduplicated. |
smarter
reviewed
Dec 24, 2017
| @@ -26,7 +26,7 @@ class Driver extends DotClass { | |||
| if (fileNames.nonEmpty) | |||
| try { | |||
| val run = compiler.newRun | |||
| run.compile(fileNames) | |||
| run.compile(fileNames.distinct) | |||
There was a problem hiding this comment.
Not sure this is a great thing to do:
- It doesn't deduplicate between
Foo.scalaand/a/b/c/Foo.scala - List#distinct is O(n^2), that's not great when compiling 10000 files.
There was a problem hiding this comment.
Then maybe I should keep only the fix on the TASTY ones. With those the compiler crashes. With dotc Foo.scala Foo.scala the compiler will emit the error saying that the class is duplicated, which is already fine.
The implementation of List@distinct I see is in SeqLike and it does look O(n).
There was a problem hiding this comment.
Ah indeed, List#distinct uses a hashset so it's probably more like n*log(n) which is acceptable. But why does the compiler crash when compiling twice the same TASTY file? Could we get it to output an error instead?
nicolasstucki
force-pushed
the
fix-decompiler-on-duplicates
branch
from
183985c to
72ca652
Compare
nicolasstucki
force-pushed
the
fix-decompiler-on-duplicates
branch
from
72ca652 to
367bf61
Compare
nicolasstucki
changed the title
smarter
reviewed
Dec 24, 2017
| unit.pickled += (cls -> cls.unpickler.unpickler.bytes) | ||
| cls.unpickler = null | ||
| Some(unit) | ||
| if (cls.unpickler == null) None // Has already been loaded by some other compilation unit |
smarter
approved these changes
Dec 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not, we would create two compilation units that try to load the same class.